[flang-commits] [flang] [llvm] [mlir] [Flang][OpenMP] Add support for scope construct (PR #193098)

[Tom Eccles via flang-commits]

================
@@ -2395,10 +2395,11 @@ class OpenMPIRBuilder {
   /// or direct value.
   /// \param IsTeamsReduction   Optional flag set if it is a teams
   ///                           reduction.
-  LLVM_ABI InsertPointOrErrorTy createReductions(
-      const LocationDescription &Loc, InsertPointTy AllocaIP,
-      ArrayRef<ReductionInfo> ReductionInfos, ArrayRef<bool> IsByRef,
-      bool IsNoWait = false, bool IsTeamsReduction = false);
+  LLVM_ABI InsertPointOrErrorTy
+  createReductions(const LocationDescription &Loc, InsertPointTy AllocaIP,
+                   ArrayRef<ReductionInfo> ReductionInfos,
+                   ArrayRef<bool> IsByRef, bool IsNoWait = false,
+                   bool IsTeamsReduction = false, bool IsNoTree = false);
----------------
tblah wrote:

>From your explanation in the commit message: should `IsNoWait = true` always imply `IsNoTree` (if so, that would probably be best done in a separate patch)? Or perhaps this should just be fixed in the runtime

https://github.com/llvm/llvm-project/pull/193098