[flang-commits] [flang] [flang][NFC] Converted five tests from old lowering to new lowering (part 42) (PR #191751)

via flang-commits flang-commits at lists.llvm.org
Sun Apr 12 19:50:17 PDT 2026


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-flang-fir-hlfir

Author: Eugene Epshteyn (eugeneepshteyn)

<details>
<summary>Changes</summary>

Tests converted from test/Lower/Intrinsics: storage_size.f90, sum.f90, system_clock.f90, trailz.f90, transfer.f90

---

Patch is 53.19 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/191751.diff


5 Files Affected:

- (modified) flang/test/Lower/Intrinsics/storage_size.f90 (+29-52) 
- (modified) flang/test/Lower/Intrinsics/sum.f90 (+36-59) 
- (modified) flang/test/Lower/Intrinsics/system_clock.f90 (+85-112) 
- (modified) flang/test/Lower/Intrinsics/trailz.f90 (+40-31) 
- (modified) flang/test/Lower/Intrinsics/transfer.f90 (+26-92) 


``````````diff
diff --git a/flang/test/Lower/Intrinsics/storage_size.f90 b/flang/test/Lower/Intrinsics/storage_size.f90
index d17602b4d4089..bf38ed8892b14 100644
--- a/flang/test/Lower/Intrinsics/storage_size.f90
+++ b/flang/test/Lower/Intrinsics/storage_size.f90
@@ -1,4 +1,4 @@
-! RUN: bbc -emit-fir -hlfir=false %s -o - | FileCheck %s
+! RUN: %flang_fc1 -emit-hlfir %s -o - | FileCheck %s
 
 module storage_size_test
   type :: p1
@@ -21,23 +21,20 @@ integer function unlimited_polymorphic_pointer(p) result(size)
   end function
 
 ! CHECK-LABEL: func.func @_QMstorage_size_testPunlimited_polymorphic_pointer(
-! CHECK-SAME: %[[P:.*]]: !fir.ref<!fir.class<!fir.ptr<none>>> {fir.bindc_name = "p"}) -> i32 {
-! CHECK: %[[SIZE:.*]] = fir.alloca i32 {bindc_name = "size", uniq_name = "_QMstorage_size_testFunlimited_polymorphic_pointerEsize"}
-! CHECK: %[[LOAD_P:.*]] = fir.load %[[P]] : !fir.ref<!fir.class<!fir.ptr<none>>>
+! CHECK-SAME: %[[P:.*]]: !fir.ref<!fir.class<!fir.ptr<none>>>
+! CHECK: %[[pDecl:.*]]:2 = hlfir.declare %[[P]]
+! CHECK: %[[LOAD_P:.*]] = fir.load %[[pDecl]]#0 : !fir.ref<!fir.class<!fir.ptr<none>>>
 ! CHECK: %[[P_ADDR:.*]] = fir.box_addr %[[LOAD_P]] : (!fir.class<!fir.ptr<none>>) -> !fir.ptr<none>
 ! CHECK: %[[P_ADDR_I64:.*]] = fir.convert %[[P_ADDR]] : (!fir.ptr<none>) -> i64
 ! CHECK: %[[C0:.*]] = arith.constant 0 : i64
 ! CHECK: %[[IS_NULL_ADDR:.*]] = arith.cmpi eq, %[[P_ADDR_I64]], %[[C0]] : i64
 ! CHECK: fir.if %[[IS_NULL_ADDR]] {
-! CHECK:   fir.call @_FortranAReportFatalUserError(%{{.*}}, %{{.*}}, %{{.*}}) {{.*}} : (!fir.ref<i8>, !fir.ref<i8>, i32) -> ()
+! CHECK:   fir.call @_FortranAReportFatalUserError
 ! CHECK: }
-! CHECK: %[[LOAD_P:.*]] = fir.load %[[P]] : !fir.ref<!fir.class<!fir.ptr<none>>>
-! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[LOAD_P]] : (!fir.class<!fir.ptr<none>>) -> i32
+! CHECK: %[[LOAD_P2:.*]] = fir.load %[[pDecl]]#0 : !fir.ref<!fir.class<!fir.ptr<none>>>
+! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[LOAD_P2]] : (!fir.class<!fir.ptr<none>>) -> i32
 ! CHECK: %[[C8:.*]] = arith.constant 8 : i32
 ! CHECK: %[[BITS:.*]] = arith.muli %[[ELE_SIZE]], %[[C8]] : i32
-! CHECK: fir.store %[[BITS]] to %[[SIZE]] : !fir.ref<i32>
-! CHECK: %[[RES:.*]] = fir.load %[[SIZE]] : !fir.ref<i32>
-! CHECK: return %[[RES]] : i32
 
   integer function unlimited_polymorphic_allocatable(p) result(size)
     class(*), allocatable :: p
@@ -45,23 +42,20 @@ integer function unlimited_polymorphic_allocatable(p) result(size)
   end function
 
 ! CHECK-LABEL: func.func @_QMstorage_size_testPunlimited_polymorphic_allocatable(
-! CHECK-SAME: %[[P:.*]]: !fir.ref<!fir.class<!fir.heap<none>>> {fir.bindc_name = "p"}) -> i32 {
-! CHECK: %[[SIZE:.*]] = fir.alloca i32 {bindc_name = "size", uniq_name = "_QMstorage_size_testFunlimited_polymorphic_allocatableEsize"}
-! CHECK: %[[LOAD_P:.*]] = fir.load %[[P]] : !fir.ref<!fir.class<!fir.heap<none>>>
+! CHECK-SAME: %[[P:.*]]: !fir.ref<!fir.class<!fir.heap<none>>>
+! CHECK: %[[pDecl:.*]]:2 = hlfir.declare %[[P]]
+! CHECK: %[[LOAD_P:.*]] = fir.load %[[pDecl]]#0 : !fir.ref<!fir.class<!fir.heap<none>>>
 ! CHECK: %[[P_ADDR:.*]] = fir.box_addr %[[LOAD_P]] : (!fir.class<!fir.heap<none>>) -> !fir.heap<none>
 ! CHECK: %[[P_ADDR_I64:.*]] = fir.convert %[[P_ADDR]] : (!fir.heap<none>) -> i64
 ! CHECK: %[[C0:.*]] = arith.constant 0 : i64
 ! CHECK: %[[IS_NULL_ADDR:.*]] = arith.cmpi eq, %[[P_ADDR_I64]], %[[C0]] : i64
 ! CHECK: fir.if %[[IS_NULL_ADDR]] {
-! CHECK:   fir.call @_FortranAReportFatalUserError(%{{.*}}, %{{.*}}, %{{.*}}) {{.*}} : (!fir.ref<i8>, !fir.ref<i8>, i32) -> ()
+! CHECK:   fir.call @_FortranAReportFatalUserError
 ! CHECK: }
-! CHECK: %[[LOAD_P:.*]] = fir.load %[[P]] : !fir.ref<!fir.class<!fir.heap<none>>>
-! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[LOAD_P]] : (!fir.class<!fir.heap<none>>) -> i32
+! CHECK: %[[LOAD_P2:.*]] = fir.load %[[pDecl]]#0 : !fir.ref<!fir.class<!fir.heap<none>>>
+! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[LOAD_P2]] : (!fir.class<!fir.heap<none>>) -> i32
 ! CHECK: %[[C8:.*]] = arith.constant 8 : i32
 ! CHECK: %[[BITS:.*]] = arith.muli %[[ELE_SIZE]], %[[C8]] : i32
-! CHECK: fir.store %[[BITS]] to %[[SIZE]] : !fir.ref<i32>
-! CHECK: %[[RES:.*]] = fir.load %[[SIZE]] : !fir.ref<i32>
-! CHECK: return %[[RES]] : i32
 
   integer function polymorphic_pointer(p) result(size)
     class(p1), pointer :: p
@@ -69,15 +63,12 @@ integer function polymorphic_pointer(p) result(size)
   end function
 
 ! CHECK-LABEL: func.func @_QMstorage_size_testPpolymorphic_pointer(
-! CHECK-SAME: %[[P:.*]]: !fir.ref<!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>> {fir.bindc_name = "p"}) -> i32 {
-! CHECK: %[[SIZE:.*]] = fir.alloca i32 {bindc_name = "size", uniq_name = "_QMstorage_size_testFpolymorphic_pointerEsize"}
-! CHECK: %[[LOAD_P:.*]] = fir.load %[[P]] : !fir.ref<!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>>
+! CHECK-SAME: %[[P:.*]]: !fir.ref<!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>>
+! CHECK: %[[pDecl:.*]]:2 = hlfir.declare %[[P]]
+! CHECK: %[[LOAD_P:.*]] = fir.load %[[pDecl]]#0 : !fir.ref<!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>>
 ! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[LOAD_P]] : (!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>) -> i32
 ! CHECK: %[[C8:.*]] = arith.constant 8 : i32
 ! CHECK: %[[BITS:.*]] = arith.muli %[[ELE_SIZE]], %[[C8]] : i32
-! CHECK: fir.store %[[BITS]] to %[[SIZE]] : !fir.ref<i32>
-! CHECK: %[[RES:.*]] = fir.load %[[SIZE]] : !fir.ref<i32>
-! CHECK: return %[[RES]] : i32
 
   integer function polymorphic(p) result(size)
     class(p1) :: p
@@ -85,14 +76,11 @@ integer function polymorphic(p) result(size)
   end function
 
 ! CHECK-LABEL: func.func @_QMstorage_size_testPpolymorphic(
-! CHECK-SAME: %[[P:.*]]: !fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>> {fir.bindc_name = "p"}) -> i32 {
-! CHECK: %[[SIZE:.*]] = fir.alloca i32 {bindc_name = "size", uniq_name = "_QMstorage_size_testFpolymorphicEsize"}
-! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[P]] : (!fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>) -> i32
+! CHECK-SAME: %[[P:.*]]: !fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>
+! CHECK: %[[pDecl:.*]]:2 = hlfir.declare %[[P]]
+! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[pDecl]]#1 : (!fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>) -> i32
 ! CHECK: %[[C8:.*]] = arith.constant 8 : i32
 ! CHECK: %[[BITS:.*]] = arith.muli %[[ELE_SIZE]], %[[C8]] : i32
-! CHECK: fir.store %[[BITS]] to %[[SIZE]] : !fir.ref<i32>
-! CHECK: %[[RES:.*]] = fir.load %[[SIZE]] : !fir.ref<i32>
-! CHECK: return %[[RES]] : i32
 
   integer(8) function polymorphic_rank(p) result(size)
     class(p1) :: p
@@ -100,14 +88,11 @@ integer(8) function polymorphic_rank(p) result(size)
   end function
 
 ! CHECK-LABEL: func.func @_QMstorage_size_testPpolymorphic_rank(
-! CHECK-SAME: %[[P:.*]]: !fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>> {fir.bindc_name = "p"}) -> i64 {
-! CHECK: %[[SIZE:.*]] = fir.alloca i64 {bindc_name = "size", uniq_name = "_QMstorage_size_testFpolymorphic_rankEsize"}
-! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[P]] : (!fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>) -> i64
+! CHECK-SAME: %[[P:.*]]: !fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>
+! CHECK: %[[pDecl:.*]]:2 = hlfir.declare %[[P]]
+! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[pDecl]]#1 : (!fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>) -> i64
 ! CHECK: %[[C8:.*]] = arith.constant 8 : i64
 ! CHECK: %[[BITS:.*]] = arith.muli %[[ELE_SIZE]], %[[C8]] : i64
-! CHECK: fir.store %[[BITS]] to %[[SIZE]] : !fir.ref<i64>
-! CHECK: %[[RES:.*]] = fir.load %[[SIZE]] : !fir.ref<i64>
-! CHECK: return %[[RES]] : i64
 
   integer function polymorphic_value(t) result(size)
     type(p3) :: t
@@ -115,22 +100,14 @@ integer function polymorphic_value(t) result(size)
   end function
 
 ! CHECK-LABEL: func.func @_QMstorage_size_testPpolymorphic_value(
-! CHECK-SAME: %[[T:.*]]: !fir.ref<!fir.type<_QMstorage_size_testTp3{p:!fir.class<!fir.ptr<!fir.array<?x!fir.type<_QMstorage_size_testTp1{a:i32}>>>>}>> {fir.bindc_name = "t"}) -> i32 {
-! CHECK: %[[ALLOCA:.*]] = fir.alloca i32 {bindc_name = "size", uniq_name = "_QMstorage_size_testFpolymorphic_valueEsize"}
-! CHECK: %[[COORD_P:.*]] = fir.coordinate_of %[[T]], p : (!fir.ref<!fir.type<_QMstorage_size_testTp3{p:!fir.class<!fir.ptr<!fir.array<?x!fir.type<_QMstorage_size_testTp1{a:i32}>>>>}>>) -> !fir.ref<!fir.class<!fir.ptr<!fir.array<?x!fir.type<_QMstorage_size_testTp1{a:i32}>>>>>
-! CHECK: %[[LOAD_COORD_P:.*]] = fir.load %[[COORD_P]] : !fir.ref<!fir.class<!fir.ptr<!fir.array<?x!fir.type<_QMstorage_size_testTp1{a:i32}>>>>>
-! CHECK: %[[C0:.*]] = arith.constant 0 : index
-! CHECK: %[[BOX_DIMS:.*]]:3 = fir.box_dims %[[LOAD_COORD_P]], %[[C0]] : (!fir.class<!fir.ptr<!fir.array<?x!fir.type<_QMstorage_size_testTp1{a:i32}>>>>, index) -> (index, index, index)
-! CHECK: %[[C1:.*]] = arith.constant 1 : i64
-! CHECK: %[[DIMI64:.*]] = fir.convert %[[BOX_DIMS]]#0 : (index) -> i64
-! CHECK: %[[IDX:.*]] = arith.subi %[[C1]], %[[DIMI64]] : i64
-! CHECK: %[[COORD_OF:.*]] = fir.coordinate_of %[[LOAD_COORD_P]], %[[IDX]] : (!fir.class<!fir.ptr<!fir.array<?x!fir.type<_QMstorage_size_testTp1{a:i32}>>>>, i64) -> !fir.ref<!fir.type<_QMstorage_size_testTp1{a:i32}>>
-! CHECK: %[[BOXED:.*]] = fir.embox %[[COORD_OF]] source_box %[[LOAD_COORD_P]] : (!fir.ref<!fir.type<_QMstorage_size_testTp1{a:i32}>>, !fir.class<!fir.ptr<!fir.array<?x!fir.type<_QMstorage_size_testTp1{a:i32}>>>>) -> !fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>
-! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[BOXED]] : (!fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>) -> i32
+! CHECK-SAME: %[[T:.*]]: !fir.ref<!fir.type<_QMstorage_size_testTp3{p:!fir.class<!fir.ptr<!fir.array<?x!fir.type<_QMstorage_size_testTp1{a:i32}>>>>}>>
+! CHECK: %[[tDecl:.*]]:2 = hlfir.declare %[[T]]
+! CHECK: %[[FIELD_P:.*]] = hlfir.designate %[[tDecl]]#0{"p"}
+! CHECK: %[[LOAD_P:.*]] = fir.load %[[FIELD_P]]
+! CHECK: %[[C1:.*]] = arith.constant 1 : index
+! CHECK: %[[ELEM:.*]] = hlfir.designate %[[LOAD_P]] (%[[C1]])
+! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[ELEM]] : (!fir.class<!fir.type<_QMstorage_size_testTp1{a:i32}>>) -> i32
 ! CHECK: %[[C8:.*]] = arith.constant 8 : i32
 ! CHECK: %[[SIZE:.*]] = arith.muli %[[ELE_SIZE]], %[[C8]] : i32
-! CHECK: fir.store %[[SIZE]] to %[[ALLOCA]] : !fir.ref<i32>
-! CHECK: %[[RET:.*]] = fir.load %[[ALLOCA]] : !fir.ref<i32>
-! CHECK: return %[[RET]] : i32
 
 end module
diff --git a/flang/test/Lower/Intrinsics/sum.f90 b/flang/test/Lower/Intrinsics/sum.f90
index 454d564684e89..1150084dfa57b 100644
--- a/flang/test/Lower/Intrinsics/sum.f90
+++ b/flang/test/Lower/Intrinsics/sum.f90
@@ -1,63 +1,41 @@
 ! REQUIRES: x86-registered-target
-! RUN: bbc -target x86_64-unknown-linux-gnu --use-desc-for-alloc=false -emit-fir -hlfir=false %s -o - | FileCheck %s
+! RUN: %flang_fc1 -triple x86_64-unknown-linux-gnu -emit-hlfir %s -o - | FileCheck %s
 
 ! CHECK-LABEL: func @_QPsum_test(
-! CHECK-SAME: %[[arg0:.*]]: !fir.box<!fir.array<?xi32>>{{.*}}) -> i32 {
+! CHECK-SAME: %[[arg0:.*]]: !fir.box<!fir.array<?xi32>>{{.*}}) -> i32
 integer function sum_test(a)
 integer :: a(:)
-! CHECK-DAG:  %[[c0:.*]] = arith.constant 0 : index
-! CHECK-DAG:  %[[a1:.*]] = fir.absent !fir.box<i1>
-! CHECK-DAG: %[[a3:.*]] = fir.convert %[[arg0]] : (!fir.box<!fir.array<?xi32>>) -> !fir.box<none>
-! CHECK-DAG:  %[[a5:.*]] = fir.convert %[[c0]] : (index) -> i32
-! CHECK-DAG:  %[[a6:.*]] = fir.convert %[[a1]] : (!fir.box<i1>) -> !fir.box<none>
+! CHECK: hlfir.declare %[[arg0]]
 sum_test = sum(a)
-! CHECK:  %{{.*}} = fir.call @_FortranASumInteger4(%[[a3]], %{{.*}}, %{{.*}}, %[[a5]], %[[a6]]) {{.*}}: (!fir.box<none>, !fir.ref<i8>, i32, i32, !fir.box<none>) -> i32
+! CHECK: hlfir.sum {{.*}} : (!fir.box<!fir.array<?xi32>>) -> i32
 end function
 
 ! CHECK-LABEL: func @_QPsum_test2(
-! CHECK-SAME: %[[arg0:.*]]: !fir.box<!fir.array<?x?xi32>>{{.*}}, %[[arg1:.*]]: !fir.box<!fir.array<?xi32>>{{.*}}) {
+! CHECK-SAME: %[[arg0:.*]]: !fir.box<!fir.array<?x?xi32>>{{.*}}, %[[arg1:.*]]: !fir.box<!fir.array<?xi32>>
 subroutine sum_test2(a,r)
 integer :: a(:,:)
 integer :: r(:)
 ! CHECK-DAG:  %[[c2_i32:.*]] = arith.constant 2 : i32
-! CHECK-DAG:  %[[a0:.*]] = fir.alloca !fir.box<!fir.heap<!fir.array<?xi32>>>
-! CHECK-DAG:  %[[a1:.*]] = fir.absent !fir.box<i1>
-! CHECK-DAG:  %[[a6:.*]] = fir.convert %[[a0]] : (!fir.ref<!fir.box<!fir.heap<!fir.array<?xi32>>>>) -> !fir.ref<!fir.box<none>>
-! CHECK-DAG:  %[[a7:.*]] = fir.convert %[[arg0]] : (!fir.box<!fir.array<?x?xi32>>) -> !fir.box<none>
-! CHECK-DAG:  %[[a9:.*]] = fir.convert %[[a1]] : (!fir.box<i1>) -> !fir.box<none>
+! CHECK-DAG: %[[aDecl:.*]]:2 = hlfir.declare %[[arg0]]
+! CHECK-DAG: %[[rDecl:.*]]:2 = hlfir.declare %[[arg1]]
 r = sum(a,dim=2)
-! CHECK:  fir.call @_FortranASumDim(%[[a6]], %[[a7]], %[[c2_i32]], %{{.*}}, %{{.*}}, %[[a9]]) {{.*}}: (!fir.ref<!fir.box<none>>, !fir.box<none>, i32, !fir.ref<i8>, i32, !fir.box<none>) -> ()
-! CHECK-DAG: %[[a11:.*]] = fir.load %[[a0]] : !fir.ref<!fir.box<!fir.heap<!fir.array<?xi32>>>>
-! CHECK-DAG:  %[[a13:.*]] = fir.box_addr %[[a11]] : (!fir.box<!fir.heap<!fir.array<?xi32>>>) -> !fir.heap<!fir.array<?xi32>>
-! CHECK-DAG:  fir.freemem %[[a13]]
+! CHECK: hlfir.sum %[[aDecl]]#0 dim %[[c2_i32]] {{.*}} : (!fir.box<!fir.array<?x?xi32>>, i32) -> !hlfir.expr<?xi32>
 end subroutine
 
 ! CHECK-LABEL: func @_QPsum_test3(
-! CHECK-SAME: %[[arg0:.*]]: !fir.box<!fir.array<?xcomplex<f32>>>{{.*}}) -> complex<f32> {
+! CHECK-SAME: %[[arg0:.*]]: !fir.box<!fir.array<?xcomplex<f32>>>{{.*}}) -> complex<f32>
 complex function sum_test3(a)
 complex :: a(:)
-! CHECK-DAG:  %[[c0:.*]] = arith.constant 0 : index
-! CHECK-DAG:  %[[a0:.*]] = fir.alloca complex<f32>
-! CHECK-DAG:  %[[a3:.*]] = fir.absent !fir.box<i1>
-! CHECK-DAG:  %[[a6:.*]] = fir.convert %[[arg0]] : (!fir.box<!fir.array<?xcomplex<f32>>>) -> !fir.box<none>
-! CHECK-DAG:  %[[a8:.*]] = fir.convert %[[c0]] : (index) -> i32
-! CHECK-DAG:  %[[a9:.*]] = fir.convert %[[a3]] : (!fir.box<i1>) -> !fir.box<none>
 sum_test3 = sum(a)
-! CHECK:  fir.call @_FortranACppSumComplex4(%[[a0]], %[[a6]], %{{.*}}, %{{.*}}, %[[a8]], %[[a9]]) {{.*}}: (!fir.ref<complex<f32>>, !fir.box<none>, !fir.ref<i8>, i32, i32, !fir.box<none>) -> ()
+! CHECK: hlfir.sum {{.*}} : (!fir.box<!fir.array<?xcomplex<f32>>>) -> complex<f32>
 end function
 
 ! CHECK-LABEL: func @_QPsum_test4(
-! CHECK-SAME: %[[arg0:.*]]: !fir.box<!fir.array<?xcomplex<f80>>>{{.*}}) -> complex<f80> {
+! CHECK-SAME: %[[arg0:.*]]: !fir.box<!fir.array<?xcomplex<f80>>>{{.*}}) -> complex<f80>
 complex(10) function sum_test4(x)
 complex(10):: x(:)
-! CHECK-DAG:  %[[c0:.*]] = arith.constant 0 : index
-! CHECK-DAG:  %[[a0:.*]] = fir.alloca complex<f80>
 sum_test4 = sum(x)
-! CHECK-DAG: %[[a2:.*]] = fir.absent !fir.box<i1>
-! CHECK-DAG: %[[a5:.*]] = fir.convert %[[arg0]] : (!fir.box<!fir.array<?xcomplex<f80>>>) -> !fir.box<none>
-! CHECK-DAG:  %[[a7:.*]] = fir.convert %[[c0]] : (index) -> i32
-! CHECK-DAG:  %[[a8:.*]] = fir.convert %[[a2]] : (!fir.box<i1>) -> !fir.box<none>
-! CHECK: fir.call @_FortranACppSumComplex10(%[[a0]], %[[a5]], %{{.*}}, %{{.*}}, %[[a7]], %{{[0-9]+}}) {{.*}}: (!fir.ref<complex<f80>>, !fir.box<none>, !fir.ref<i8>, i32, i32, !fir.box<none>) -> ()
+! CHECK: hlfir.sum {{.*}} : (!fir.box<!fir.array<?xcomplex<f80>>>) -> complex<f80>
 end
 
 ! CHECK-LABEL: func @_QPsum_test_optional(
@@ -66,8 +44,12 @@ integer function sum_test_optional(mask, x)
 integer :: x(:)
 logical, optional :: mask(:)
 sum_test_optional = sum(x, mask=mask)
-! CHECK:  %[[VAL_9:.*]] = fir.convert %[[VAL_0]] : (!fir.box<!fir.array<?x!fir.logical<4>>>) -> !fir.box<none>
-! CHECK:  fir.call @_FortranASumInteger4(%{{.*}}, %{{.*}}, %{{.*}}, %{{.*}}, %[[VAL_9]]) {{.*}}: (!fir.box<none>, !fir.ref<i8>, i32, i32, !fir.box<none>) -> i32
+! CHECK-DAG:  %[[maskDecl:.*]]:2 = hlfir.declare %[[VAL_0]] {{.*}}optional
+! CHECK-DAG:  %[[xDecl:.*]]:2 = hlfir.declare %{{.*}} {{.*}}{uniq_name = "_QFsum_test_optionalEx"}
+! CHECK:  %[[isPresent:.*]] = fir.is_present %[[maskDecl]]#0
+! CHECK:  %[[absent:.*]] = fir.absent !fir.box<!fir.array<?x!fir.logical<4>>>
+! CHECK:  %[[opt:.*]] = arith.select %[[isPresent]], %[[maskDecl]]#1, %[[absent]]
+! CHECK:  hlfir.sum %[[xDecl]]#0 mask %[[opt]] {{.*}} : (!fir.box<!fir.array<?xi32>>, !fir.box<!fir.array<?x!fir.logical<4>>>) -> i32
 end function
 
 ! CHECK-LABEL: func @_QPsum_test_optional_2(
@@ -76,16 +58,16 @@ integer function sum_test_optional_2(mask, x)
 integer :: x(:)
 logical, pointer :: mask(:)
 sum_test_optional = sum(x, mask=mask)
-! CHECK:  %[[VAL_4:.*]] = fir.load %[[VAL_0]] : !fir.ref<!fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>>
+! CHECK:  %[[maskDecl:.*]]:2 = hlfir.declare %[[VAL_0]]
+! CHECK:  %[[VAL_4:.*]] = fir.load %[[maskDecl]]#0 : !fir.ref<!fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>>
 ! CHECK:  %[[VAL_5:.*]] = fir.box_addr %[[VAL_4]] : (!fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>) -> !fir.ptr<!fir.array<?x!fir.logical<4>>>
 ! CHECK:  %[[VAL_6:.*]] = fir.convert %[[VAL_5]] : (!fir.ptr<!fir.array<?x!fir.logical<4>>>) -> i64
 ! CHECK:  %[[VAL_7:.*]] = arith.constant 0 : i64
 ! CHECK:  %[[VAL_8:.*]] = arith.cmpi ne, %[[VAL_6]], %[[VAL_7]] : i64
-! CHECK:  %[[VAL_9:.*]] = fir.load %[[VAL_0]] : !fir.ref<!fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>>
+! CHECK:  %[[VAL_9:.*]] = fir.load %[[maskDecl]]#0 : !fir.ref<!fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>>
 ! CHECK:  %[[VAL_10:.*]] = fir.absent !fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>
 ! CHECK:  %[[VAL_11:.*]] = arith.select %[[VAL_8]], %[[VAL_9]], %[[VAL_10]] : !fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>
-! CHECK:  %[[VAL_18:.*]] = fir.convert %[[VAL_11]] : (!fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>) -> !fir.box<none>
-! CHECK:  fir.call @_FortranASumInteger4(%{{.*}}, %{{.*}}, %{{.*}}, %{{.*}}, %[[VAL_18]]) {{.*}}: (!fir.box<none>, !fir.ref<i8>, i32, i32, !fir.box<none>) -> i32
+! CHECK:  hlfir.sum {{.*}} mask %[[VAL_11]] {{.*}} : (!fir.box<!fir.array<?xi32>>, !fir.box<!fir.ptr<!fir.array<?x!fir.logical<4>>>>) -> i32
 end function
 
 ! CHECK-LABEL: func @_QPsum_test_optional_3(
@@ -94,14 +76,13 @@ integer function sum_test_optional_3(mask, x)
 integer :: x(:)
 logical, optional :: mask(10)
 sum_test_optional = sum(x, mask=mask)
-! CHECK:  %[[VAL_2:.*]] = arith.constant 10 : index
-! CHECK:  %[[VAL_5:.*]] = fir.is_present %[[VAL_0]] : (!fir.ref<!fir.array<10x!fir.logical<4>>>) -> i1
-! CHECK:  %[[VAL_6:.*]] = fir.shape %[[VAL_2]] : (index) -> !fir.shape<1>
-! CHECK:  %[[VAL_7:.*]] = fir.embox %[[VAL_0]](%[[VAL_6]]) : (!fir.ref<!fir.array<10x!fir.logical<4>>>, !fir.shape<1>) -> !fir.box<!fir.array<10x!fir.logical<4>>>
+! CHECK:  %[[maskDecl:.*]]:2 = hlfir.declare %[[VAL_0]]
+! CHECK:  %[[VAL_5:.*]] = fir.is_present %[[maskDecl]]#0 : (!fir.ref<!fir.array<10x!fir.logical<4>>>) -> i1
+! CHECK:  %[[VAL_6:.*]] = fir.shape
+! CHECK:  %[[VAL_7:.*]] = fir.embox %[[maskDecl]]#0(%[[VAL_6]])
 ! CHECK:  %[[VAL_8:.*]] = fir.absent !fir.box<!fir.array<10x!fir.logical<4>>>
 ! CHECK:  %[[VAL_9:.*]] = arith.select %[[VAL_5]], %[[VAL_7]], %[[VAL_8]] : !fir.box<!fir.array<10x!fir.logical<4>>>
-! CHECK:  %[[VAL_18:.*]] = fir.convert %[[VAL_9]] : (!fir.box<!fir.array<10x!fir.logical<4>>>) -> !fir.box<none>
-! CHECK:  fir.call @_FortranASumInteger4(%{{.*}}, %{{.*}}, %{{.*}}, %{{.*}}, %[[VAL_18]]) {{.*}}: (!fir.box<none>, !fir.ref<i8>, i32, i32, !fir.box<none>) -> i32
+! CHECK:  hlfir.sum {{.*}} mask %[[VAL_9]] {{.*}} : (!fir.box<!fir.array<?xi32>>, !fir.box<!fir.array<10x!fir.logical<4>>>) -> i32
 end function
 
 ! CHECK-LABEL: func @_QPsum_test_optional_4(
@@ -117,17 +98,13 @@ integer function sum_test_optional_4(x, use_mask)
   ! CHECK: fir.call @_QPset_mask
 end if
 sum_test_optional = sum(x, mask=mask)
-! CHECK:  %[[VAL_20:.*]] = fir.load %[[VAL_3:.*]] : !fir.ref<!fir.heap<!fir.array<?x!fir.logical<4>>>>
-! CHECK:  %[[VAL_21:.*]] = fir.convert %[[VAL_20]] : (!fir.heap<!fir.array<?x!fir.logical<4>>>) -> i64
-! CHECK:  %[[VAL_22:.*]] = arith.constant 0 : i64
-! CHECK:  %[[VAL_23:.*]] = arith.cmpi ne, %[[VAL_21]], %[[VAL_22]] : i64
-! CHECK:  %[[VAL_24:.*]] = fir.load %[[VAL_4:.*]] : !fir.ref<index>
-! CHECK:  %[[VAL_25:.*]] = fir.load %[[VAL_5:.*]] : !fir.ref<index>
-! CHECK:  %[[VAL_26:.*]] = fir.load %[[VAL_3]] : !fir.ref<!fir.heap<!fir.array<?x!fir.logical<4>>>>
-! CHECK:  %[[VAL_27:.*]] = fir.shape_shift %[[VAL_24]], %[[VAL_25]] : (index, index...
[truncated]

``````````

</details>


https://github.com/llvm/llvm-project/pull/191751


More information about the flang-commits mailing list