[flang-commits] [flang] [Flang] mark safe external globals as dso_local (PR #189709)

[David Truby via flang-commits]

DavidTruby wrote:

There's a possible complication here on Windows that this stops the symbols being able to be marked dllexport/dllimport directly. I'm not really sure how _much_ this matters as we don't have a syntax for dllexport/dllimport, and you can't refer to them directly from a dll anyway as they're mangled, so you'd probably want to write a BIND(C) interface and then a C stub that dllexport/dllimports them anyway. If we decide to add a syntax for this as an extension we can always come back and add a condition here anyway I think. 

I don't think this should block you from merging, I just wanted to mention it for posterity just in case it does cause issues down the line!

https://github.com/llvm/llvm-project/pull/189709