[flang-commits] [flang] f9cf60b - [flang][NFC] Update comments (#160186)
via flang-commits
flang-commits at lists.llvm.org
Mon Sep 22 13:08:25 PDT 2025
Author: Andre Kuhlenschmidt
Date: 2025-09-22T13:08:22-07:00
New Revision: f9cf60b0c1329bab94cc19693d9e06a6713cb5bc
URL: https://github.com/llvm/llvm-project/commit/f9cf60b0c1329bab94cc19693d9e06a6713cb5bc
DIFF: https://github.com/llvm/llvm-project/commit/f9cf60b0c1329bab94cc19693d9e06a6713cb5bc.diff
LOG: [flang][NFC] Update comments (#160186)
Just an update to comments that I accidentally did on a testing repo and
didn't get included in the final merge of
https://github.com/llvm/llvm-project/pull/159477.
Added:
Modified:
flang/lib/Semantics/check-call.cpp
Removed:
################################################################################
diff --git a/flang/lib/Semantics/check-call.cpp b/flang/lib/Semantics/check-call.cpp
index 41c18a35f9678..797fd067b8185 100644
--- a/flang/lib/Semantics/check-call.cpp
+++ b/flang/lib/Semantics/check-call.cpp
@@ -811,7 +811,7 @@ static void CheckExplicitDataArg(const characteristics::DummyDataObject &dummy,
// General implementation of F'23 15.5.2.5 note 5
// Adds a less specific error message for any copy-out that could overwrite
// a unread value in the actual argument.
- // Occurences of volatileOrAsyncNeedsTempDiagnosticIssued = true indicate a
+ // Occurences of `volatileOrAsyncNeedsTempDiagnosticIssued = true` indicate a
// more specific error message has already been issued. We might be able to
// clean this up by switching the coding style of MayNeedCopy to be more like
// WhyNotDefinable.
@@ -828,8 +828,8 @@ static void CheckExplicitDataArg(const characteristics::DummyDataObject &dummy,
// If there are any cases where we don't need a copy and some other compiler
// does, we issue a portability warning here.
if (context.ShouldWarn(common::UsageWarning::Portability)) {
- // Nag, GFortran, and NVFortran all error on this case, even though it is
- // ok, prossibly as an over-restriction of F'23 C1548.
+ // 3 other compilers error on this case even though it is ok.
+ // Possibly as an over-restriction of F'23 C1548.
if (!copyOutNeeded && !volatileOrAsyncNeedsTempDiagnosticIssued &&
(!dummyIsValue && (dummyIsAsynchronous || dummyIsVolatile)) &&
!(actualIsAsynchronous || actualIsVolatile) &&
@@ -842,7 +842,7 @@ static void CheckExplicitDataArg(const characteristics::DummyDataObject &dummy,
actual.AsFortran(), dummyName,
dummyIsAsynchronous ? "ASYNCHRONOUS" : "VOLATILE");
}
- // Probably an over-restriction of F'23 15.5.2.5 note 5
+ // Possibly an over-restriction of F'23 15.5.2.5 note 5
if (copyOutNeeded && !volatileOrAsyncNeedsTempDiagnosticIssued) {
if ((dummyIsVolatile && !actualIsVolatile && !actualIsAsynchronous) ||
(dummyIsAsynchronous && !actualIsVolatile && !actualIsAsynchronous)) {
More information about the flang-commits
mailing list