[flang-commits] [flang] [Flang][OpenMP] Fix USM `close` semantics and `use_device_ptr` (PR #163258)

[Akash Banerjee via flang-commits]

TIFitis wrote:

> I have a bit of a worry that this won't handle c_ptr inside of derived types, but I imagine the intent is just to handle standalone c_ptr's for the moment and I am good with that and the derived types support can come in a later PR.

I'll work on adding derived type support soon.

> It might be worth testing these changes with the aomp smoke tests for Flang as well, it has a few tests related to use_dev_ptr/addr in there :-)

Thanks for the suggestion, aomp smoke-fort is clean.

> I also have some work in the next week or two that'll land downstream and eventually float upstream related to swapping to attach map for descriptor mapping, but hopefully it won't have any adverse affects on this PR, I'll fix it myself of course if it does, but might need to ask for a bit of help!

Sure, more than happy to help :)

> Would it please be possible to get an IR generation test for the changeset?

I've added a lowering test to the PR.

> Otherwise this PR LGTM, thank you for the fix!

Thanks for the review :D


https://github.com/llvm/llvm-project/pull/163258