[flang-commits] [clang] [flang] [llvm] [Offload] Rename and move 'clang-offload-packager' -> 'llvm-offload-binary' (PR #161438)

James Henderson via flang-commits flang-commits at lists.llvm.org
Fri Oct 3 00:14:10 PDT 2025


================
@@ -98,10 +92,9 @@ static Error bundleImages() {
     StringSaver Saver(Alloc);
     DenseMap<StringRef, StringRef> Args = getImageArguments(Image, Saver);
 
-    if (!Args.count("triple") || !Args.count("file"))
-      return createStringError(
-          inconvertibleErrorCode(),
-          "'file' and 'triple' are required image arguments");
+    if (!Args.count("file"))
----------------
jh7370 wrote:

I've got no real stakes in this tool, but if it were me, I'd avoid what look to me like functional changes at the same time as moving the tool. I'd put them in a change either immediately after or before, if they're strongly tied to the rename.

https://github.com/llvm/llvm-project/pull/161438


More information about the flang-commits mailing list