[flang-commits] [clang] [flang] [Flang][FIR] Introduce FIRToCoreMLIR pass. (PR #168703)

[Ming Yan via flang-commits]

================
@@ -117,13 +132,12 @@ void addFIRToLLVMPass(mlir::PassManager &pm,
   options.typeDescriptorsRenamedForAssembly =
       !disableCompilerGeneratedNamesConversion;
   options.ComplexRange = config.ComplexRange;
-  addPassConditionally(pm, disableFirToLlvmIr,
-                       [&]() { return fir::createFIRToLLVMPass(options); });
+  options.LowerThroughCoreMLIR = config.LowerThroughCoreMLIR;
+  pm.addPass(fir::createFIRToLLVMPass(options));
----------------
NexMing wrote:

I just don’t want to end up with a bunch of `addPassConditionally` calls after the `LowerThroughCoreMLIR` condition. However, I’m starting to think that splitting `FIR->LLVM` and `FIR->Core MLIR->LLVM` into two separate functions might be a better approach.

https://github.com/llvm/llvm-project/pull/168703