[flang-commits] [clang] [flang] [flang][driver] Do not allow -module-dir to be joined to the value (PR #168748)

[Tarun Prabhu via flang-commits]

tarunprabhu wrote:

> As much as I would like this, I fear CMake has to be fixed first: https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/Compiler/LLVMFlang-Fortran.cmake?ref_type=heads#L10

I am happy to do that. It's probably better to weed this out if we can because it may well cause us obscure problems in the future.

Replacing the -module-dir in `cmake` with `-J` is probably the most reasonable thing to do. `-J` will work in both joined and separate styles and it is already working as expected in flang, so there should not be any disruption.

Do you have any suggestions on how to go about it? If we do push the change to `cmake`, do we wait until the next cmake release before merging this in?

https://github.com/llvm/llvm-project/pull/168748