[flang-commits] [flang] [flang] Characterize allocation based on MemAlloc effect instead of pattern matching (PR #166806)

[Slava Zakharin via flang-commits]

https://github.com/vzakhari commented:

Thank you for updating the tests, Susan! Sorry that you have to deal with it, but I consider your change as an improvement :)

Many of these FIR-lowering tests are not relevant any more, but we still need to keep them working.  I suppose those `fir.alloca` operations that are used by unused `[hl]fir.declare` will stay, since `[hl]fir.declare` has side effects. So for HLFIR-lowering your change should only affect `fir` allocation operations for which we do not create `[hl]fir.declare` and that are unused, and it is good that the compiler will just remove them now.

https://github.com/llvm/llvm-project/pull/166806