[flang-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [clang] Refactor option-related code from clangDriver into new clangOptions library (PR #163659)

[Aaron Ballman via flang-commits]

AaronBallman wrote:

> Hi, is this PR ready to merge? It has approvals from the Clang driver and options maintainers, and the follow-up PR (#165277), which includes this patch, has approval from Flang driver maintainer @tarunprabhu (can you confirm if that also applies to this patch?).
> 
> I’m happy to wait a bit longer for any additional feedback on the RFC. Before merging, I’ll also retest the build locally with `BUILD_SHARED_LIBS=ON` (on Linux) for `clang`, `clang-tools-extra`, `flang` and `lldb`.
> 
> Thanks everyone for reviewing!!

I think it's almost ready to merge; I'd say we should give the RFC another two (or more) days so folks have a chance to weigh in with any concerns (downstream folks sometimes take a little bit longer to respond to RFCs). I would say if there are no negative comments by Friday, I'll accept the RFC and we should be fine to land.

https://github.com/llvm/llvm-project/pull/163659