[flang-commits] [flang] [mlir] [RFC][mlir] ViewLikeOpInterface method for detecting partial views. (PR #164020)

[Matthias Springer via flang-commits]

================
@@ -40,17 +40,19 @@ using namespace mlir;
 static constexpr unsigned maxUnderlyingValueSearchDepth = 10;
 
 /// Given a value, collect all of the underlying values being addressed.
-static void collectUnderlyingAddressValues(Value value, unsigned maxDepth,
-                                           DenseSet<Value> &visited,
-                                           SmallVectorImpl<Value> &output);
+static void
+collectUnderlyingAddressValues(Value value, unsigned maxDepth,
+                               DenseMap<Value, bool> &visited, bool maybeOffset,
+                               SmallVectorImpl<std::pair<Value, bool>> &output);
----------------
matthias-springer wrote:

This sounds like a bug in the existing alias analysis to me, irrespective of your change. Am I missing something?

https://github.com/llvm/llvm-project/pull/164020