[flang-commits] [flang] [flang] Fix volatile attribute propagation on allocatables (PR #139183)

[Tom Eccles via flang-commits]

================
@@ -1536,20 +1536,51 @@ bool fir::ConvertOp::canBeConverted(mlir::Type inType, mlir::Type outType) {
          areRecordsCompatible(inType, outType);
 }
 
+// In general, ptrtoint-like conversions are allowed to lose volatility
+// information because they are either:
+//
+// 1. passing an entity to an external function and there's nothing we can do
+//    about volatility after that happens, or
+// 2. for code generation, at which point we represent volatility with
+// attributes
+//    on the LLVM instructions and intrinsics.
----------------
tblah wrote:

ultra-nit
```suggestion
// 1. passing an entity to an external function and there's nothing we can do
//    about volatility after that happens, or
// 2. for code generation, at which point we represent volatility with
//    attributes
//    on the LLVM instructions and intrinsics.
```

https://github.com/llvm/llvm-project/pull/139183