[flang-commits] [flang] [flang][openacc] Allow open acc routines from other modules. (PR #136012)

[Andre Kuhlenschmidt via flang-commits]

================
@@ -137,22 +140,28 @@ class OpenACCRoutineDeviceTypeInfo {
   void set_isGang(bool value = true) { isGang_ = value; }
   unsigned gangDim() const { return gangDim_; }
   void set_gangDim(unsigned value) { gangDim_ = value; }
-  const std::string *bindName() const {
-    return bindName_ ? &*bindName_ : nullptr;
+  const std::variant<std::string, SymbolRef> *bindName() const {
----------------
akuhlens wrote:

Could you say more about this? I think I am returning the variant here, which means I am returning both alternatives. So I am not certain what you are poking at. If you are referring to the use of optional instead of just storing the possible null pointer, I was just mimicking what had been done previously while adding what I needed. Happy to fix this up and return an optional here.

I will add a comment to this effect, but the string is the bindc name and the SymbolRef is the name of an fortran managed symbol binding that will require mangling in lowering. Seperated so that I wasn't forced to call into name mangling during name resolution.

https://github.com/llvm/llvm-project/pull/136012