[flang-commits] [flang] [flang] Use precompiled parsing headers (PR #130600)

[David Truby via flang-commits]

================
@@ -13,7 +13,6 @@
 #include "flang/Frontend/CompilerInstance.h"
 #include "flang/Frontend/CompilerInvocation.h"
 #include "flang/Frontend/TextDiagnosticPrinter.h"
-#include "flang/Parser/parsing.h"
----------------
DavidTruby wrote:

I don't think you need/want to remove these headers for this to work, and there's a couple of disadvantages to doing so: for example, clangd/other editor support might break if the right "real" includes aren't there.

These includes will get immediately skipped over in favour of the `.pch` includes anyway, because of the guard macros (`#ifndef FLANG_FRONTEND_COMPILERINSTANCE_H` etc) and the `.pch` being included first. So I think it's best to leave them in.

https://github.com/llvm/llvm-project/pull/130600