[flang-commits] [flang] [Flang] Change sizeof argument name to "x" (PR #130189)

[via flang-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-flang-semantics

Author: Andre Kuhlenschmidt (akuhlens)

<details>
<summary>Changes</summary>

This closes #<!-- -->128610 by fixing the name of the argument to the sizeof function to be "x" and adds a test.

---
Full diff: https://github.com/llvm/llvm-project/pull/130189.diff


2 Files Affected:

- (modified) flang/lib/Evaluate/intrinsics.cpp (+1-1) 
- (added) flang/test/Intrinsics/sizeof.f90 (+10) 


``````````diff
diff --git a/flang/lib/Evaluate/intrinsics.cpp b/flang/lib/Evaluate/intrinsics.cpp
index fe691e85ee011..65f17f06667dd 100644
--- a/flang/lib/Evaluate/intrinsics.cpp
+++ b/flang/lib/Evaluate/intrinsics.cpp
@@ -936,7 +936,7 @@ static const IntrinsicInterface genericIntrinsicFunction[]{
             OptionalDIM, // unless array is assumed-size
             SizeDefaultKIND},
         KINDInt, Rank::scalar, IntrinsicClass::inquiryFunction},
-    {"sizeof", {{"a", AnyData, Rank::anyOrAssumedRank}}, SubscriptInt,
+    {"sizeof", {{"x", AnyData, Rank::anyOrAssumedRank}}, SubscriptInt,
         Rank::scalar, IntrinsicClass::inquiryFunction},
     {"spacing", {{"x", SameReal}}, SameReal},
     {"spread",
diff --git a/flang/test/Intrinsics/sizeof.f90 b/flang/test/Intrinsics/sizeof.f90
new file mode 100644
index 0000000000000..c7bd9788a3ce4
--- /dev/null
+++ b/flang/test/Intrinsics/sizeof.f90
@@ -0,0 +1,10 @@
+! RUN: %python %S/test_errors.py %s %flang_fc1
+  character(len=20) :: a, b
+  if (sizeof(a) == sizeof(x=b)) then
+    print *, "pass"
+  else
+    print *, "fail"
+  end if
+  ERROR! unknown keyword argument to intrinsic 'sizeof'
+  print *, sizeof(a=a)
+end
\ No newline at end of file

``````````

</details>


https://github.com/llvm/llvm-project/pull/130189