[flang-commits] [flang] [llvm] [mlir] [Flang][OpenMP][MLIR] Implement close, present and ompx_hold modifiers for Flang maps (PR #129586)

Sergio Afonso via flang-commits flang-commits at lists.llvm.org
Thu Mar 6 07:47:41 PST 2025


================
@@ -1093,15 +1093,16 @@ bool ClauseProcessor::processMap(
     }
 
     if (typeMods) {
+      // TODO: Still requires "self" modifier, the latter which is OpenMP 6.0+
+      // and requires adding to the parser/semantic pipeline before here.
----------------
skatrak wrote:

Nit: I think this comment could get outdated pretty easily, since it's so specific. I think we can just say we're missing support for the "self" modifier here and potentially explain that this patch doesn't add it because it's missing parsing/semantics support in the commit message instead.

Not a big deal, so you can leave it in if you prefer.

https://github.com/llvm/llvm-project/pull/129586


More information about the flang-commits mailing list