[flang-commits] [compiler-rt] [flang] [llvm] [AArch64] fix trampoline implementation: use X15 (PR #126743)

Kazu Hirata via flang-commits flang-commits at lists.llvm.org
Wed Jun 11 22:02:14 PDT 2025


kazutakahirata wrote:

@vtjnash I've landed 99638537cd19b84252685a3dd56535a4d54d690e to fix a warning from this PR, which also shows up in the buildbot failure above.

Meanwhile, do you actually mean to override `0x0f` with `0x0f`?

```
  switch (CC) {
  default:
    NestReg = 0x0f; // X15
    LLVM_FALLTHROUGH;  // <-  I added this line.
  case CallingConv::ARM64EC_Thunk_Native:
  case CallingConv::ARM64EC_Thunk_X64:
    // Must be kept in sync with AArch64CallingConv.td
    NestReg = 0x04; // X4
    break;
  }
```

I tried inserting `break;` in place of `LLVM_FALLTHROUGH;`, but that triggered a test failure.  so I guess `0x04` needs to override `0x0f`.  Is that correct?  Thanks in advance!


https://github.com/llvm/llvm-project/pull/126743


More information about the flang-commits mailing list