[flang-commits] [flang] [flang][Driver] Remove check for pic/pie settings without driver flags (PR #143530)

[Krzysztof Parzyszek via flang-commits]

kparzysz wrote:

I think LLVM_ENABLE_PIC controls whether PIC is used to compile LLVM itself.

Here are my cmake flags:
cmake -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_LIT_ARGS='-sv -j64' -DCMAKE_BUILD_TYPE=Release -DCLANG_DEFAULT_LINKER=lld -DLLVM_BUILD_TESTS=ON -DLLVM_INCLUDE_TESTS=ON -DCLANG_INCLUDE_TESTS=ON -DLLVM_TARGETS_TO_BUILD=all -DLLVM_ENABLE_RUNTIMES='openmp;offload;compiler-rt;libcxx;libcxxabi;libunwind' -DLLVM_ENABLE_PROJECTS='bolt;clang;clang-tools-extra;flang;lld;lldb;mlir;polly;pstl' -DBUILD_SHARED_LIBS=ON -DLIBOMPTARGET_PLUGINS_TO_BUILD='amdgpu;host' -DCLANG_DEFAULT_PIE_ON_LINUX=OFF -DLIBOMP_OMPT_SUPPORT=OFF -DLLVM_OMIT_DAGISEL_COMMENTS=OFF

Maybe it's the CLANG_DEFAULT_PIE_ON_LINUX=OFF?  In any case, a check like that should probably be guarded by something.

https://github.com/llvm/llvm-project/pull/143530