[flang-commits] [flang] [flang][cli] Add diagnostic flags to the CLI (PR #142022)

[Peter Klausler via flang-commits]

================
@@ -94,57 +154,41 @@ LanguageFeatureControl::LanguageFeatureControl() {
   warnLanguage_.set(LanguageFeature::NullActualForAllocatable);
 }
 
-// Ignore case and any inserted punctuation (like '-'/'_')
-static std::optional<char> GetWarningChar(char ch) {
-  if (ch >= 'a' && ch <= 'z') {
-    return ch;
-  } else if (ch >= 'A' && ch <= 'Z') {
-    return ch - 'A' + 'a';
-  } else if (ch >= '0' && ch <= '9') {
-    return ch;
-  } else {
-    return std::nullopt;
+// Take a string from the Cli and apply it to the LanguageFeatureControl.
+// Return true if the option was applied recognized.
----------------
klausler wrote:

The comment should probably have only one of its last two words.

https://github.com/llvm/llvm-project/pull/142022