[flang-commits] [flang] [mlir] [Flang][OpenMP] Fix to resolve the crash with SIMD aligned clause. (PR #150612)

[Kiran Chandramohan via flang-commits]

kiranchandramohan wrote:


> I'm not sure about this approach. The warnings from the mlir to llvmir conversion will not be formatted as proper diagnostics and will not be controllable using the usual flags influencing other diagnostics.

This is a concern for me as well. But my assumption was different parts of the compiler will be providing warnings and it is for the driver to format them and control appropriately. This might not be the situation now.


> Things like this should be done in flang semantic checks to ensure consistency.

> It is good to catch this for other users of the OpenMP MLIR dialect too. In this case I would personally update the operation verifiers to not allow these unsupported alignment values.

The issue I had with these two points was that this warning is not part of the OpenMP standard. Other compilers do not seem to be emitting the warning.
The warning seems to be to address a limitation of the LLVM IR assume alignment mechanism which we are using while lowering to LLVM.

Since @tblah seems to have a strong opinion here. May be we should discuss it with others as well and then take a decision. Either way please go with @tblah's and other maintainers (@kparzysz @skatrak) direction.


https://github.com/llvm/llvm-project/pull/150612