[flang-commits] [flang] [mlir] [MLIR][LLVMIR][DLTI] Add #llvm.target, #llvm.data_layout and TargetAttrInterface (PR #145899)

[Renato Golin via flang-commits]

rengolin wrote:

> In that particular case, I'd prefer an empty chip or a string indicating this is a special case. Because as you say, there are a lot of targets where the chip does carry a lot info, therefore I think we should handle the common case of required chip.

Empty string would be fine, yes. If Arm is fine with making it compulsory (and not empty), we should. Validation would be so much easier. 

If not, then we may need some custom validation per target to make sure that for the ones where the info is in the chip, it must not be empty.

https://github.com/llvm/llvm-project/pull/145899