[flang-commits] [flang] [mlir] [MLIR][LLVMIR][DLTI] Add #llvm.target, #llvm.data_layout and TargetAttrInterface (PR #145899)

[Renato Golin via flang-commits]

rengolin wrote:

> Also, I'm not sure whether making `chip` optional is a good idea.

Older Arm targets didn't need a chip because the micro-architecture was encoded in the target triple. There can be the case where passing a chip name is not just confusing but wrong (if the target doesn't recognize the chip but can build a target with the correct set of features). For x86 and GPUs the chip names carry a lot of information, that is not encoded in the triple, so become necessary.

Arguably we don't usually care about armv7 or lower, but I'll let @banach-space comment on that. 

https://github.com/llvm/llvm-project/pull/145899