[flang-commits] [flang] b6ea04a - [flang][NFC] Fix build-time warning (#149549)

[via flang-commits]

Author: Peter Klausler
Date: 2025-07-18T13:45:25-07:00
New Revision: b6ea04a37b2a41e24bb999e5a9b6a7bd2b576085

URL: https://github.com/llvm/llvm-project/commit/b6ea04a37b2a41e24bb999e5a9b6a7bd2b576085
DIFF: https://github.com/llvm/llvm-project/commit/b6ea04a37b2a41e24bb999e5a9b6a7bd2b576085.diff

LOG: [flang][NFC] Fix build-time warning (#149549)

Don't increment the LHS variable of an assignment that also uses that
variable on the RHS.

Added: 
    

Modified: 
    flang/lib/Semantics/resolve-labels.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Semantics/resolve-labels.cpp b/flang/lib/Semantics/resolve-labels.cpp
index 27e259fab3873..9454ef9fe928a 100644
--- a/flang/lib/Semantics/resolve-labels.cpp
+++ b/flang/lib/Semantics/resolve-labels.cpp
@@ -492,10 +492,9 @@ class ParseTreeAnalyzer {
     // Uppercase the name of the main program, so that its symbol name
     // would be unique from similarly named non-main-program symbols.
     auto upperCaseCharBlock = [](const parser::CharBlock &cb) {
-      char *ch{const_cast<char *>(cb.begin())};
-      char *endCh{ch + cb.size()};
-      while (ch != endCh) {
-        *ch++ = parser::ToUpperCaseLetter(*ch);
+      auto ch{const_cast<char *>(cb.begin())};
+      for (char *endCh{ch + cb.size()}; ch != endCh; ++ch) {
+        *ch = parser::ToUpperCaseLetter(*ch);
       }
     };
     const parser::CharBlock *progName{nullptr};