[flang-commits] [flang] [flang][NFC] Fix build-time warning (PR #149549)

[Peter Klausler via flang-commits]

https://github.com/klausler created https://github.com/llvm/llvm-project/pull/149549

Don't increment the LHS variable of an assignment that also uses that variable on the RHS.

>From db0880f45cb80e98381a1da4c829a80fe31308a4 Mon Sep 17 00:00:00 2001
From: Peter Klausler <pklausler at nvidia.com>
Date: Fri, 18 Jul 2025 09:40:15 -0700
Subject: [PATCH] [flang][NFC] Fix build-time warning

Don't increment the LHS variable of an assignment that also
uses that variable on the RHS.
---
 flang/lib/Semantics/resolve-labels.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/flang/lib/Semantics/resolve-labels.cpp b/flang/lib/Semantics/resolve-labels.cpp
index 27e259fab38738..9454ef9fe928ad 100644
--- a/flang/lib/Semantics/resolve-labels.cpp
+++ b/flang/lib/Semantics/resolve-labels.cpp
@@ -492,10 +492,9 @@ class ParseTreeAnalyzer {
     // Uppercase the name of the main program, so that its symbol name
     // would be unique from similarly named non-main-program symbols.
     auto upperCaseCharBlock = [](const parser::CharBlock &cb) {
-      char *ch{const_cast<char *>(cb.begin())};
-      char *endCh{ch + cb.size()};
-      while (ch != endCh) {
-        *ch++ = parser::ToUpperCaseLetter(*ch);
+      auto ch{const_cast<char *>(cb.begin())};
+      for (char *endCh{ch + cb.size()}; ch != endCh; ++ch) {
+        *ch = parser::ToUpperCaseLetter(*ch);
       }
     };
     const parser::CharBlock *progName{nullptr};