[flang-commits] [flang] [flang][cuda][NFC] Remove TODO implemented in semantic (PR #148058)

[via flang-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-flang-fir-hlfir

Author: Valentin Clement (バレンタイン クレメン) (clementval)

<details>
<summary>Changes</summary>

This is implemented here: https://github.com/llvm/llvm-project/blob/838701a5403efbaf6e25254377a6f033acee6681/flang/lib/Semantics/check-cuda.cpp#L764

Keep the assert in place as security, 

---
Full diff: https://github.com/llvm/llvm-project/pull/148058.diff


1 Files Affected:

- (modified) flang/lib/Lower/Bridge.cpp (-2) 


``````````diff
diff --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp
index 987fd3095fdf6..cd55d10314740 100644
--- a/flang/lib/Lower/Bridge.cpp
+++ b/flang/lib/Lower/Bridge.cpp
@@ -4842,8 +4842,6 @@ class FirConverter : public Fortran::lower::AbstractConverter {
                   .detailsIf<Fortran::semantics::ObjectEntityDetails>()) {
         if (details->cudaDataAttr() &&
             *details->cudaDataAttr() != Fortran::common::CUDADataAttr::Pinned) {
-          // TODO: This should probably being checked in semantic and give a
-          // proper error.
           assert(
               nbDeviceResidentObject <= 1 &&
               "Only one reference to the device resident object is supported");

``````````

</details>


https://github.com/llvm/llvm-project/pull/148058