[flang-commits] [flang] [Flang][Doc] NFC: Minor fix for headings (PR #147077)
Kiran Chandramohan via flang-commits
flang-commits at lists.llvm.org
Fri Jul 4 08:20:17 PDT 2025
https://github.com/kiranchandramohan created https://github.com/llvm/llvm-project/pull/147077
Use a top level section to ensure that there is only one entry in the flang.llvm.org/docs page.
Also generate a table of contents.
>From f6ed8d7508b3edf6e2897d478c259c18d5bb8be5 Mon Sep 17 00:00:00 2001
From: Kiran Chandramohan <kiran.chandramohan at arm.com>
Date: Fri, 4 Jul 2025 16:05:14 +0100
Subject: [PATCH] [Flang][Doc] NFC: Minor fix for headings
Use a top level section to ensure that there is only one entry in
the flang.llvm.org/docs page.
Also generate a table of contents.
---
flang/docs/OpenMP-declare-target.md | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/flang/docs/OpenMP-declare-target.md b/flang/docs/OpenMP-declare-target.md
index 45062469007b6..478db2d004c87 100644
--- a/flang/docs/OpenMP-declare-target.md
+++ b/flang/docs/OpenMP-declare-target.md
@@ -7,7 +7,15 @@
-->
-# Introduction to Declare Target
+# OpenMP Declare Target
+
+```{contents}
+---
+local:
+---
+```
+
+## Introduction to Declare Target
In OpenMP `declare target` is a directive that can be applied to a function or
variable (primarily global) to notate to the compiler that it should be
@@ -55,7 +63,7 @@ in this case, leave off the `declare target` from the function and it
would be implicitly marked `declare target any` (for both host and device),
as it's been utilised within a target region.
-# Declare Target as represented in the OpenMP Dialect
+## Declare Target as represented in the OpenMP Dialect
In the OpenMP Dialect `declare target` is not represented by a specific
`operation`. Instead, it's an OpenMP dialect specific `attribute` that can be
@@ -89,7 +97,7 @@ llvm::dyn_cast<mlir::omp::DeclareTargetInterface>(Op.getOperation());
declareTargetGlobal.isDeclareTarget();
```
-# Declare Target Fortran OpenMP Lowering
+## Declare Target Fortran OpenMP Lowering
The initial lowering of `declare target` to MLIR for both use-cases is done
inside of the usual OpenMP lowering in flang/lib/Lower/OpenMP.cpp. However,
@@ -145,7 +153,7 @@ to the way `threadprivate` handles these cases, we raise and initialize the
variable as an internal `GlobalOp` and apply the attribute. This occurs in the
flang/lib/Lower/OpenMP.cpp function `genDeclareTargetIntGlobal`.
-# Declare Target Transformation Passes for Flang
+## Declare Target Transformation Passes for Flang
There are currently two passes within Flang that are related to the processing
of `declare target`:
@@ -173,7 +181,7 @@ While this infrastructure could be generally applicable to more than just Flang,
it is only utilised in the Flang frontend, so it resides there rather than in
the OpenMP dialect codebase.
-# Declare Target OpenMP Dialect To LLVM-IR Lowering
+## Declare Target OpenMP Dialect To LLVM-IR Lowering
The OpenMP dialect lowering of `declare target` is done through the
`amendOperation` flow, as it's not an `operation` but rather an
@@ -228,7 +236,7 @@ place. It may be possible to store this information in the OMPIRBuilder and
then perform this cleanup process on finalization, but this is open for
discussion and implementation still.
-# Current Support
+## Current Support
For the moment, `declare target` should work for:
* Marking functions/subroutines and function/subroutine interfaces for
More information about the flang-commits
mailing list