[flang-commits] [flang] [flang] fix skip-external-rtti-definition for ppc (PR #146826)

via flang-commits flang-commits at lists.llvm.org
Thu Jul 3 00:37:31 PDT 2025


https://github.com/jeanPerier created https://github.com/llvm/llvm-project/pull/146826

PPC does not use comdat. There is no need to check for that in the test, just remove it.

Fix for https://lab.llvm.org/buildbot/#/builders/201/builds/5278

>From 3d85a279cb5591fd9a3ccdb497864052c691f7d3 Mon Sep 17 00:00:00 2001
From: Jean Perier <jperier at nvidia.com>
Date: Thu, 3 Jul 2025 00:33:24 -0700
Subject: [PATCH] [flang] fix skip-external-rtti-definition for ppc

---
 flang/test/Integration/skip-external-rtti-definition.F90 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/flang/test/Integration/skip-external-rtti-definition.F90 b/flang/test/Integration/skip-external-rtti-definition.F90
index f86cc069b304d..35a5d559efa5e 100644
--- a/flang/test/Integration/skip-external-rtti-definition.F90
+++ b/flang/test/Integration/skip-external-rtti-definition.F90
@@ -33,9 +33,9 @@ subroutine needs_descriptor(x)
 
 #endif
 
-! LINKONCE-DAG: @_QMmodule_external_type_definitionEXnXt1 = linkonce_odr constant [2 x i8] c"t1", comdat
+! LINKONCE-DAG: @_QMmodule_external_type_definitionEXnXt1 = linkonce_odr constant [2 x i8] c"t1"
 ! LINKONCE-DAG: @_QMmodule_external_type_definitionEXdtXt1 = linkonce_odr constant {{.*}} {
-! LINKONCE-DAG: @_QMmodule_same_unit_type_definitionEXnXt2 = linkonce_odr constant [2 x i8] c"t2", comdat
+! LINKONCE-DAG: @_QMmodule_same_unit_type_definitionEXnXt2 = linkonce_odr constant [2 x i8] c"t2"
 ! LINKONCE-DAG: @_QMmodule_same_unit_type_definitionEXdtXt2 = linkonce_odr constant {{.*}} {
 
 ! EXTERNAL-NOT: @_QMmodule_external_type_definitionEXnXt1



More information about the flang-commits mailing list