[flang-commits] [flang] [flang][Lower] Explicitly instantiate all templates from Utils.h (PR #125216)
via flang-commits
flang-commits at lists.llvm.org
Fri Jan 31 12:21:45 PST 2025
https://github.com/jeanPerier commented:
Thanks for having identified the cost here.
I think the HashEvaluateExpr and IsEqualEvaluateExpr classes may just not be needed to exposed at all, they could be defined and used in Utils.cpp. I see only one usage of them outside of the Utils.h header, and this is in `lib/Lower/IterationSpace.cpp` in some function that is used for the legacy lowering and could just be moved to Utils.h/Utils.cpp for now.
I see little point of having all entry points accessible for future use cases (if needed, newly required ones could be exposed, but having all them may just be overkill unless there is a strong use case).
https://github.com/llvm/llvm-project/pull/125216
More information about the flang-commits
mailing list