[flang-commits] [flang] [flang] fix isSimplyContiguous and isOptional hlfir::Entity methods (PR #125215)

Slava Zakharin via flang-commits flang-commits at lists.llvm.org
Fri Jan 31 08:48:11 PST 2025


================
@@ -121,8 +121,14 @@ class HlfirIntrinsicConversion : public mlir::OpRewritePattern<OP> {
         // simplified since the fir.box lowered here are now guarenteed to
         // contain the local lower bounds thanks to the hlfir.declare (the extra
         // rebox can be removed).
-        auto [exv, cleanup] =
-            hlfir::translateToExtendedValue(loc, builder, entity);
+        // When taking arguments as descriptors, the runtime expect absent
+        // OPTIONAL to be a nullptr to a descriptor, lowering has already
+        // prepared such descriptors        // as needed, hence set
----------------
vzakhari wrote:

nit:
```suggestion
        // prepared such descriptors as needed, hence set
```

https://github.com/llvm/llvm-project/pull/125215


More information about the flang-commits mailing list