[flang-commits] [flang] [llvm] [mlir] [Flang] Add lowering support for depobj in depend clause (PR #124523)

[Thirumalai Shaktivel via flang-commits]

Thirumalai-Shaktivel wrote:

Thanks for the review, @tblah.

The `DepAlloca` data will required for the task creation, so I think it should be available during the runtime (Mostly, Asynchronous).
Regarding the `StackSave` and `Restore` usage, I think it must be a mistake and might not required. But, I have a doubt, how does the memory deallocation happen here?

I took reference from Clang's IR and it seems Clang uses stack save and restore to clean up the block.
They handle it here: https://github.com/llvm/llvm-project/blob/55be370f375416f615a840d1c0cabe2c819e6bbb/clang/lib/CodeGen/CGDecl.cpp#L1652-L1675 and the array is created here:https://github.com/llvm/llvm-project/blob/55be370f375416f615a840d1c0cabe2c819e6bbb/clang/lib/CodeGen/CGOpenMPRuntime.cpp#L3815-L3817


https://github.com/llvm/llvm-project/pull/124523