[flang-commits] [flang] [mlir] [mlir] share argument attributes interface between calls and callables (PR #123176)

[via flang-commits]

================
@@ -14,6 +14,7 @@
 #ifndef MLIR_INTERFACES_CALLINTERFACES_H
 #define MLIR_INTERFACES_CALLINTERFACES_H
 
+#include "mlir/IR/OpImplementation.h"
----------------
jeanPerier wrote:

No, because of `OpAsmParser::Argument`  usage, I think it is not possible to forward declare nested types.

Either that class should be hoisted in a new OpAsmParserArgument class (a bit outside of the scope of this patch), or the helpers need to be in a different header (maybe that is why FunctionImplementation.h exists).

What do you think, is it worth splitting the header to avoid that include?

https://github.com/llvm/llvm-project/pull/123176