[flang-commits] [clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

[Nikolas Klauser via flang-commits]

philnik777 wrote:

> It looks like one of the header changes here is expensive, adding 0.5% to the time to build clang. Per-file breakdown: https://llvm-compile-time-tracker.com/compare_clang.php?from=aab25f20f6c06bab7aac6fb83d54705ec4cdfadd&to=0865ecc5150b9a55ba1f9e30b6d463a66ac362a6&stat=instructions%3Au&sortBy=interestingness
> 
> Possibly the DiagnosticCategories.h include in DiagnosticIDs.h? Or maybe the additional code in the DiagnosticIDs.h header?
> 
> Is it possible to implement this feature in a way that doesn't impact build times?

I guess it's be possible to move the `CustomDiagDesc` into a separate header to avoid the `DiagnosticCategories.h` dependency in `DiagnosticIDs.h`. @AaronBallman any thoughts?


https://github.com/llvm/llvm-project/pull/119712