[flang-commits] [flang] b16c989 - [flang] Fix check for coarray actual passed to implicit interface (#123836)
via flang-commits
flang-commits at lists.llvm.org
Mon Jan 27 08:55:24 PST 2025
Author: Peter Klausler
Date: 2025-01-27T08:55:20-08:00
New Revision: b16c989697208795f6428432f9ab05c5535b6085
URL: https://github.com/llvm/llvm-project/commit/b16c989697208795f6428432f9ab05c5535b6085
DIFF: https://github.com/llvm/llvm-project/commit/b16c989697208795f6428432f9ab05c5535b6085.diff
LOG: [flang] Fix check for coarray actual passed to implicit interface (#123836)
The check for a coarray actual argument being passed to a procedure with
an implicit interface was incorrect, yielding false positives for
coindexed objects. Fix.
Added:
Modified:
flang/lib/Semantics/check-call.cpp
flang/test/Semantics/call13.f90
Removed:
################################################################################
diff --git a/flang/lib/Semantics/check-call.cpp b/flang/lib/Semantics/check-call.cpp
index ba68a0f898d469..79caf50d8597ec 100644
--- a/flang/lib/Semantics/check-call.cpp
+++ b/flang/lib/Semantics/check-call.cpp
@@ -67,10 +67,6 @@ static void CheckImplicitInterfaceArg(evaluate::ActualArgument &arg,
"Null pointer argument requires an explicit interface"_err_en_US);
} else if (auto named{evaluate::ExtractNamedEntity(*expr)}) {
const Symbol &symbol{named->GetLastSymbol()};
- if (symbol.Corank() > 0) {
- messages.Say(
- "Coarray argument requires an explicit interface"_err_en_US);
- }
if (evaluate::IsAssumedRank(symbol)) {
messages.Say(
"Assumed rank argument requires an explicit interface"_err_en_US);
diff --git a/flang/test/Semantics/call13.f90 b/flang/test/Semantics/call13.f90
index 8b203e4b715d50..3f7fb2efc8f636 100644
--- a/flang/test/Semantics/call13.f90
+++ b/flang/test/Semantics/call13.f90
@@ -22,8 +22,8 @@ subroutine s(assumedRank, coarray, class, classStar, typeStar)
call implicit10(1, 2, keyword=3) ! 15.4.2.2(1)
!ERROR: Assumed rank argument requires an explicit interface
call implicit11(assumedRank) ! 15.4.2.2(3)(c)
- !ERROR: Coarray argument requires an explicit interface
- call implicit12(coarray) ! 15.4.2.2(3)(d)
+ call implicit12(coarray) ! ok
+ call implicit12a(coarray[1]) ! ok
!ERROR: Parameterized derived type actual argument requires an explicit interface
call implicit13(pdtx) ! 15.4.2.2(3)(e)
call implicit14(class) ! ok
More information about the flang-commits
mailing list