[flang-commits] [flang] [flang] Fix spurious error due to bad expression shape calculation (PR #124323)
Peter Klausler via flang-commits
flang-commits at lists.llvm.org
Mon Jan 27 08:09:12 PST 2025
================
@@ -149,6 +152,8 @@ inline MaybeExtentExpr GetSize(const std::optional<Shape> &maybeShape) {
// Utility predicate: does an expression reference any implied DO index?
bool ContainsAnyImpliedDoIndex(const ExtentExpr &);
+// GetShape()
----------------
klausler wrote:
Yes. I like to have a comment like this appear before the implementation of a library function when that implementation is necessarily preceded by screens worth of helper functions and classes, so that it's clear that the code after the comment is leading up to something. I'm not always consistent about this, though.
https://github.com/llvm/llvm-project/pull/124323
More information about the flang-commits
mailing list