[flang-commits] [clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

[Nikolas Klauser via flang-commits]

https://github.com/philnik777 commented:

> TBH I find it somewhat confusing to have a severity in `diagnose_if` and an existing diagnostic group, which already has its own severity.

Diagnostic groups don't have severity. Individual diagnostics have severity. This just exposes the same semantics as the tablegen files. i.e. you specify a default and if that default is overridden by the command line or pragmas that severity is used instead. I'm not sure where the confusion is.


https://github.com/llvm/llvm-project/pull/119712