[flang-commits] [flang] [mlir] [flang][openmp] Changes for invoking scan Op (PR #123254)

[Sergio Afonso via flang-commits]

================
@@ -156,6 +158,8 @@ ReductionProcessor::getReductionOperation(fir::FirOpBuilder &builder,
   return builder.create<ComplexOp>(loc, op1, op2);
 }
 
+using ReductionModifier = omp::clause::Reduction::ReductionModifier;
----------------
skatrak wrote:

Nit: I believe this would be better placed in ReductionProcessor.cpp, if your intention was to simplify references to that enum in the implementation, to avoid introducing unrelated definitions into the `Fortran::lower::omp` namespace.

Let me know if you had thought of other uses of this in mind. 

https://github.com/llvm/llvm-project/pull/123254