[flang-commits] [flang] [flang][debug] Add support for common blocks. (PR #112398)

via flang-commits flang-commits at lists.llvm.org
Wed Jan 22 10:07:35 PST 2025


jieljiel wrote:

> > Hi @abidh, I'm visiting this PR and wondering if you would like to share your plan about how to proceed with this support for common blocks? Is the FIR extension that @jeanPerier suggested a prerequiste?
> 
> Hi @jieljiel
> 
> The FIR extension is the best way to detect the common block but the current approach also works. I was wondering that we can use this PR for now as it fills a missing hole in the debug support. When the extension in FIR to detect common block is available in future, we can use that and remove the DAG walking. If @jeanPerier thinks this is OK then I can rebase/update the PR and address any other comments.

@jeanPerier Would you mind letting @abidh 's PR in and then he will make adjustment based on FIR extensions later.

@abidh Would you be able to implement the required FIR extension, or you need @jeanPerier 's help working on that?

https://github.com/llvm/llvm-project/pull/112398


More information about the flang-commits mailing list