[flang-commits] [flang] [mlir] [flang][OpenMP] Unconditionally create `after_alloca` block in `allocatePrivateVars` (PR #123168)

Kareem Ergawy via flang-commits flang-commits at lists.llvm.org
Thu Jan 16 10:08:22 PST 2025


ergawy wrote:

> LGTM, thanks.
> 
> Test 1009_0029.f90 now passes on AArch64 and this change doesn't seem to break any other tests.
> 
> Some nitpicks:
> 
>     * Typo in title: Uncotionally
> 
>     * In the description we have `... we now conditionally created the after_alloca block based on the number of predecessors ...`, but wasn't it based on the number of successors?

Fixed, thanks for your diligence.

https://github.com/llvm/llvm-project/pull/123168


More information about the flang-commits mailing list