[flang-commits] [flang] [mlir] [mlir][IR] Remove factory methods from `FloatType` (PR #123026)

[via flang-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff c24ce324d56328e4b91c8797ea4935545084303e 57e19033a54bec4fb6f824a92fd1fd73f01a5844 --extensions h,cpp -- flang/include/flang/Optimizer/Builder/Runtime/RTBuilder.h flang/lib/Lower/ConvertType.cpp flang/lib/Optimizer/Builder/FIRBuilder.cpp flang/lib/Optimizer/Builder/IntrinsicCall.cpp flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp flang/lib/Optimizer/Builder/Runtime/Numeric.cpp flang/lib/Optimizer/Builder/Runtime/Reduction.cpp flang/lib/Optimizer/Builder/Runtime/Transformational.cpp flang/lib/Optimizer/CodeGen/Target.cpp flang/lib/Optimizer/Dialect/FIRType.cpp flang/unittests/Optimizer/Builder/ComplexTest.cpp flang/unittests/Optimizer/Builder/FIRBuilderTest.cpp flang/unittests/Optimizer/Builder/HLFIRToolsTest.cpp flang/unittests/Optimizer/FIRTypesTest.cpp flang/unittests/Optimizer/FortranVariableTest.cpp flang/unittests/Optimizer/RTBuilder.cpp mlir/include/mlir/IR/BuiltinTypes.h mlir/lib/CAPI/IR/BuiltinTypes.cpp mlir/lib/IR/Builders.cpp mlir/lib/IR/BuiltinTypes.cpp mlir/lib/Target/LLVMIR/DataLayoutImporter.cpp mlir/lib/Target/LLVMIR/ModuleImport.cpp mlir/test/lib/Dialect/Affine/TestVectorizationUtils.cpp mlir/test/lib/Dialect/Test/TestPatterns.cpp mlir/test/lib/Transforms/TestDialectConversion.cpp mlir/tools/tblgen-to-irdl/OpDefinitionsGen.cpp mlir/unittests/IR/AttributeTest.cpp mlir/unittests/IR/ShapedTypeTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/lib/Optimizer/Builder/IntrinsicCall.cpp b/flang/lib/Optimizer/Builder/IntrinsicCall.cpp
index 0015a1e6fa..c83304caf0 100644
--- a/flang/lib/Optimizer/Builder/IntrinsicCall.cpp
+++ b/flang/lib/Optimizer/Builder/IntrinsicCall.cpp
@@ -1921,7 +1921,7 @@ genIntrinsicCall(fir::FirOpBuilder &builder, mlir::Location loc,
                  Fortran::lower::AbstractConverter *converter) {
   IntrinsicLibrary library{builder, loc, converter};
   return std::visit(
-      [&](auto handler) -> auto{
+      [&](auto handler) -> auto {
         return genIntrinsicCallHelper(handler, resultType, args, library);
       },
       intrinsic.entry);
@@ -1936,7 +1936,7 @@ IntrinsicLibrary::genIntrinsicCall(llvm::StringRef specificName,
   if (!intrinsic.has_value())
     crashOnMissingIntrinsic(loc, specificName);
   return std::visit(
-      [&](auto handler) -> auto{
+      [&](auto handler) -> auto {
         return genIntrinsicCallHelper(handler, resultType, args, *this);
       },
       intrinsic->entry);
diff --git a/flang/lib/Optimizer/CodeGen/Target.cpp b/flang/lib/Optimizer/CodeGen/Target.cpp
index afa690d3dd..ccdf2ef2a7 100644
--- a/flang/lib/Optimizer/CodeGen/Target.cpp
+++ b/flang/lib/Optimizer/CodeGen/Target.cpp
@@ -914,18 +914,10 @@ struct TargetAArch64 : public GenericTarget<TargetAArch64> {
         .Case<mlir::IntegerType>([&](auto intTy) {
           return intTy.getWidth() == 128 ? NRegs{2, false} : NRegs{1, false};
         })
-        .Case<mlir::FloatType>([&](auto) {
-          return NRegs{1, true};
-        })
-        .Case<mlir::ComplexType>([&](auto) {
-          return NRegs{2, true};
-        })
-        .Case<fir::LogicalType>([&](auto) {
-          return NRegs{1, false};
-        })
-        .Case<fir::CharacterType>([&](auto) {
-          return NRegs{1, false};
-        })
+        .Case<mlir::FloatType>([&](auto) { return NRegs{1, true}; })
+        .Case<mlir::ComplexType>([&](auto) { return NRegs{2, true}; })
+        .Case<fir::LogicalType>([&](auto) { return NRegs{1, false}; })
+        .Case<fir::CharacterType>([&](auto) { return NRegs{1, false}; })
         .Case<fir::SequenceType>([&](auto ty) {
           assert(ty.getShape().size() == 1 &&
                  "invalid array dimensions in BIND(C)");

``````````

</details>


https://github.com/llvm/llvm-project/pull/123026