[flang-commits] [flang] [llvm] [Flang][OpenMP] Add global address space to globals for target device (PR #119585)

[Abid Qadeer via flang-commits]

abidh wrote:

> @abidh Addressed your comments as best I could, hopefully they're reasonable changes! :-) Unfortunately, I've also done a rebase which breaks the PR as it brings in some incompatible changes that'll need fixed in a seperate PR as it's related to extending the getDataLayout utilities to support the new GPU module that's occasionally in use. But it doesn't make sense to add it in this PR I think, so I'll do so in a seperate one I'll open in the near future (hopefully today) :-) And thank you very much for the review! Took me a bit to get around to addressing them as I'd hoped the other segments of the stack would have received some reviews by now so I could do it all at once, alas it was not to be!

Thanks. I skimmed through your changes and they look ok to me.

https://github.com/llvm/llvm-project/pull/119585