[flang-commits] [clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

[Nico Weber via flang-commits]

nico wrote:

>From the commit message, it sounds like this might introduce warnings that `-Werror` doesn't turn into warnings. Is that correct?

We found in chromium (and other large projects) that non-fatal warnings get ignored and over time just lead to a ton of warning spam in build output, which in turn leads to people tuning out warnings even more. We have the principle that diagnostics are either important, in which case they should be fatal and non-ignorable, or they aren't, in which case they should be silent.

https://www.linfo.org/rule_of_silence.html is along the same lines.

So it'd be nice if (assuming I read the PR description correctly) there was a way to force all warnings into errors.

(I think `#warning` currently also can't be mapped to errors, but that's luckily very rare in practice.)

https://github.com/llvm/llvm-project/pull/119712