[flang-commits] [flang] [flang] Modifications to ieee floating point environment procedures (PR #121949)
via flang-commits
flang-commits at lists.llvm.org
Thu Jan 9 14:05:41 PST 2025
vdonaldson wrote:
Thank you @rorth for taking the time to build these compilers and provide detailed analysis of what happens in these environments.
These correctness problems exist without the code in this PR. I do not understand the details necessary to fully implement this functionality in environments that do not have access to the libm calls available in linux x86 environments. And I can't currently justify additional research or effort to that end. This iteration of the PR therefore reverts to generating a compile time "not yet implemented" message for calls to these procedures in environments that do not have this libm support. The code still addresses eventual cross compilation and floating point environment data size issues. It should provide a base for eventual implementation of this functionality in additional environments whenever someone chooses to do that. As it is not obvious to me how to exercise the two lit tests only in the appropriate cases I have deleted the tests. I don't think these tests are very useful. There are end-to-end tests for these calls in Fortran test suites. That should allow this code to build in all environments and either generate correct executable code or a compile time message about missing functionality.
https://github.com/llvm/llvm-project/pull/121949
More information about the flang-commits
mailing list