[flang-commits] [flang] [Flang][OpenMP] Fix copyin allocatable lowering to MLIR (PR #122097)

via flang-commits flang-commits at lists.llvm.org
Wed Jan 8 06:01:32 PST 2025


================
@@ -1298,10 +1298,15 @@ class FirConverter : public Fortran::lower::AbstractConverter {
     } else if (isAllocatable &&
                (flags.test(Fortran::semantics::Symbol::Flag::OmpFirstPrivate) ||
                 flags.test(Fortran::semantics::Symbol::Flag::OmpCopyIn))) {
-      // For firstprivate and copyin allocatable variables, RHS must be copied
+      // For firstprivate allocatable variables, RHS must be copied
----------------
jeanPerier wrote:

I think the firstprivate case could also use the RHS allocation status too for simplicity (the LHS allocation status was just copied by the code generated by `createHostAssociateVarClone`, so it does not really matter whether RHS/LHS is used here).

https://github.com/llvm/llvm-project/pull/122097


More information about the flang-commits mailing list