[flang-commits] [flang] [mlir] [mlir][Transforms] Support 1:N mappings in `ConversionValueMapping` (PR #116524)

[Markus Böck via flang-commits]

================
@@ -1478,34 +1497,12 @@ Value ConversionPatternRewriterImpl::findOrBuildReplacementValue(
   }
   Value castValue = buildUnresolvedMaterialization(
       MaterializationKind::Source, computeInsertPoint(repl), value.getLoc(),
----------------
zero9178 wrote:

I feared that this would be the case. I fully agree with all your points, the current approach is probably the best for now. 
Could we document some of these constraints somewhere? I feel we are missing comments explaining "why" things are being done the way they are.

https://github.com/llvm/llvm-project/pull/116524