[flang-commits] [flang] [mlir] [flang][OpenMP] Implement HAS_DEVICE_ADDR clause (PR #128568)

[Sergio Afonso via flang-commits]

================
@@ -765,6 +779,7 @@ static ParseResult parseInReductionPrivateReductionRegion(
   return parseBlockArgRegion(parser, region, args);
 }
 
+// See custom<PrivateRegion> in the definition of SingleOp.
----------------
skatrak wrote:

Nit: This is used both by `SingleOp` and `DistributeOp`. I think it's good to point to `custom<XyzRegion>` in a comment for these custom parsers/printers, but specifying the exact operations that use them defeats a bit the purpose of naming them based on the clauses rather than the ops, which is to reuse them whenever possible. If we do this, we need to remember updating these comments every time we update the entry block-generating clauses applicable to ops.

https://github.com/llvm/llvm-project/pull/128568