[flang-commits] [flang] [mlir] [flang][OpenMP] Implement HAS_DEVICE_ADDR clause (PR #128568)

[Sergio Afonso via flang-commits]

================
@@ -709,8 +715,12 @@ static ParseResult parseBlockArgRegion(OpAsmParser &parser, Region &region,
   return parser.parseRegion(region, entryBlockArgs);
 }
 
-static ParseResult parseHostEvalInReductionMapPrivateRegion(
+// See custom<HasDeviceAddrHostEvalInReductionMapPrivateRegion> in the
+// definition of TargetOp.
+static ParseResult parseHasDeviceAddrHostEvalInReductionMapPrivateRegion(
----------------
skatrak wrote:

Nit: Feel free to ignore this comment, but I guess that the convention we're using to name these custom region parsers is breaking down a bit here. The idea was to list the names of all entry block argument-generating clauses, so that they could be reused among multiple operations if they happen to take the same list.

At this point, we know it's exceedingly unlikely any other op will take these, so we could potentially call this `parseTargetOpRegion` and update the `custom<>` and `printXyZRegion` names as well to match, rather than keep appending more clause names.

https://github.com/llvm/llvm-project/pull/128568