[flang-commits] [flang] [flang] Set LLVM specific attributes to fir.call's of Fortran runtime. (PR #128093)

Mon Feb 24 10:23:58 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `flang` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/17587

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
168.238 [113/18/6972] Linking CXX executable bin/llvm-opt-fuzzer
168.363 [113/17/6973] Linking CXX executable bin/llvm-split
168.517 [113/16/6974] Linking CXX executable bin/llvm-reduce
168.619 [113/15/6975] Building CXX object tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/AddDebugInfo.cpp.o
168.623 [113/14/6976] Building CXX object tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/SimplifyIntrinsics.cpp.o
169.039 [113/13/6977] Linking CXX executable bin/opt
169.113 [113/12/6978] Building CXX object tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/VScaleAttr.cpp.o
169.874 [113/11/6979] Building CXX object tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/DebugTypeGenerator.cpp.o
170.289 [113/10/6980] Building CXX object tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/FunctionAttr.cpp.o
170.907 [113/9/6981] Building CXX object tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/SetRuntimeCallAttributes.cpp.o
FAILED: tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/SetRuntimeCallAttributes.cpp.o 
ccache /usr/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/flang/lib/Optimizer/Transforms -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/lib/Optimizer/Transforms -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include -Itools/flang/include -Iinclude -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/include -isystem /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/../mlir/include -isystem tools/mlir/include -isystem tools/clang/include -isystem /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-copy -Wno-ctad-maybe-unsupported -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++1z -MD -MT tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/SetRuntimeCallAttributes.cpp.o -MF tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/SetRuntimeCallAttributes.cpp.o.d -o tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/SetRuntimeCallAttributes.cpp.o -c /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/lib/Optimizer/Transforms/SetRuntimeCallAttributes.cpp
In file included from /usr/include/c++/7/bits/basic_string.h:48:0,
                 from /usr/include/c++/7/string:52,
                 from /usr/include/c++/7/stdexcept:39,
                 from /usr/include/c++/7/optional:38,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Common/constexpr-bitset.h:20,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Common/enum-set.h:17,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Common/Fortran-consts.h:12,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Support/Fortran.h:15,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Optimizer/Dialect/CUF/Attributes/CUFAttr.h:16,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Optimizer/Dialect/FIROps.h:12,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Optimizer/Builder/FIRBuilder.h:19,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Optimizer/Builder/Runtime/RTBuilder.h:21,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/lib/Optimizer/Transforms/SetRuntimeCallAttributes.cpp:21:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/include/flang/Optimizer/Transforms/RuntimeFunctions.inc:24:1:   in constexpr expansion of ‘std::basic_string_view<char>(((const char*)(& fir::runtime::RuntimeTableEntry<fir::runtime::RuntimeTableKey<Fortran::runtime::io::IoStatementState*(int, const char*, int)>, std::integer_sequence<char, '_', 'F', 'o', 'r', 't', 'r', 'a', 'n', 'A', 'i', 'o', 'B', 'e', 'g', 'i', 'n', 'B', 'a', 'c', 'k', 's', 'p', 'a', 'c', 'e'> >::name)))’
/usr/include/c++/7/string_view:100:22: error: ‘(((const char*)(& fir::runtime::RuntimeTableEntry<fir::runtime::RuntimeTableKey<Fortran::runtime::io::IoStatementState*(int, const char*, int)>, std::integer_sequence<char, '_', 'F', 'o', 'r', 't', 'r', 'a', 'n', 'A', 'i', 'o', 'B', 'e', 'g', 'i', 'n', 'B', 'a', 'c', 'k', 's', 'p', 'a', 'c', 'e'> >::name)) != 0)’ is not a constant expression
       : _M_len{__str == nullptr ? 0 : traits_type::length(__str)},
                ~~~~~~^~~~~~~~~~
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/lib/Optimizer/Transforms/SetRuntimeCallAttributes.cpp:205:1: error: non-constant condition for static assertion
 static_assert(runtimeFuncs.Verify() && "map must be sorted");
 ^~~~~~~~~~~~~
cc1plus: warning: unrecognized command line option ‘-Wno-ctad-maybe-unsupported’
cc1plus: warning: unrecognized command line option ‘-Wno-deprecated-copy’
171.799 [113/8/6982] Building CXX object tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/GenRuntimeCallsForTest.cpp.o
176.239 [113/7/6983] Building CXX object tools/flang/lib/Optimizer/Transforms/CMakeFiles/FIRTransforms.dir/PolymorphicOpConversion.cpp.o
180.129 [113/6/6984] Building CXX object tools/flang/lib/Optimizer/Support/CMakeFiles/FIRSupport.dir/InitFIR.cpp.o
185.352 [113/5/6985] Building CXX object tools/flang/lib/Lower/CMakeFiles/FortranLower.dir/PFTBuilder.cpp.o
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/lib/Lower/PFTBuilder.cpp: In member function ‘void {anonymous}::SymbolVisitor::visitSymbol(const Fortran::semantics::Symbol&)’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/lib/Lower/PFTBuilder.cpp:2055:37: warning: unused variable ‘_’ [-Wunused-variable]
           for (const auto &[_, param] : derivedTypeSpec->parameters())
                                     ^
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-ctad-maybe-unsupported’
cc1plus: warning: unrecognized command line option ‘-Wno-deprecated-copy’
189.415 [113/4/6986] Building CXX object tools/flang/tools/fir-opt/CMakeFiles/fir-opt.dir/fir-opt.cpp.o
195.012 [113/3/6987] Building CXX object tools/flang/lib/Lower/CMakeFiles/FortranLower.dir/ConvertExpr.cpp.o
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/lib/Lower/ConvertExpr.cpp: In lambda function:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/flang/lib/Lower/ConvertExpr.cpp:4677:33: warning: unused variable ‘_’ [-Wunused-variable]

```

</details>

https://github.com/llvm/llvm-project/pull/128093