[flang-commits] [flang] [flang] Check x86 CPU and issue diagnostics (PR #127950)
Tarun Prabhu via flang-commits
flang-commits at lists.llvm.org
Thu Feb 20 08:18:59 PST 2025
tarunprabhu wrote:
> > How does `clang` check for this? Can we share some code between `clang` and `flang`?
>
> See this comment: [#97466 (comment)](https://github.com/llvm/llvm-project/issues/97466#issuecomment-2211752286)
>
> To share the code would be more work than I currently have time to do. My goal was to try to fix immediate flang crash issue for x86. (ARM doesn't crash for invalid CPU, but it does something different.) Perhaps we can fix x86 now and file a new "feature" issue for trying to get some code re-use in flang and clang?
Unless @banach-space has any objections, I am ok with it. Could you add a comment to the code explaining that this could be done better and that it is a short-term fix. You could refer to the issues and comments. Filing a feature issue will also help track it.
https://github.com/llvm/llvm-project/pull/127950
More information about the flang-commits
mailing list