[flang-commits] [clang] [flang] [flang][Driver] Add support of -fd-lines-as-comments and -fd-lines-as-code flags (PR #127605)

Tarun Prabhu via flang-commits flang-commits at lists.llvm.org
Wed Feb 19 08:23:09 PST 2025


================
@@ -6747,8 +6747,16 @@ defm backtrace : BooleanFFlag<"backtrace">, Group<gfortran_Group>;
 defm bounds_check : BooleanFFlag<"bounds-check">, Group<gfortran_Group>;
 defm check_array_temporaries : BooleanFFlag<"check-array-temporaries">, Group<gfortran_Group>;
 defm cray_pointer : BooleanFFlag<"cray-pointer">, Group<gfortran_Group>;
-defm d_lines_as_code : BooleanFFlag<"d-lines-as-code">, Group<gfortran_Group>;
-defm d_lines_as_comments : BooleanFFlag<"d-lines-as-comments">, Group<gfortran_Group>;
+defm d_lines_as_code : BooleanFFlag<"d-lines-as-code">,
+                       HelpText<"Treat fixed form lines with 'd' or 'D' in the "
+                                "first column as blank.">,
+                       Group<gfortran_Group>,
+                       Visibility<[FlangOption, FC1Option]>;
+defm d_lines_as_comments : BooleanFFlag<"d-lines-as-comments">,
+                           HelpText<"Treat fixed form lines with 'd' or 'D' in "
+                                    "the first column as comments.">,
+                           Group<gfortran_Group>,
+                           Visibility<[FlangOption, FC1Option]>;
----------------
tarunprabhu wrote:

Nice catch Kiran!

It looks like the `gfortran_Group` was created in 2013, well before `flang`. I assume that his was from back when `clang` would silently pass unsupported files to `gfortran`. The patch you referenced does not seem to have moved a known option to `f_Group`. But it does seem like the right thing to do. 

Do we want to eventually move all supported `gfortran` flags to `f_Group`? If so, we can start with this and move the others over in time.

https://github.com/llvm/llvm-project/pull/127605


More information about the flang-commits mailing list