[flang-commits] [flang] [flang] add ABI argument attributes in indirect calls (PR #126896)
via flang-commits
flang-commits at lists.llvm.org
Wed Feb 12 07:50:06 PST 2025
jeanPerier wrote:
> Is there an example that shows how this change affects final LLVM IR?
In the MLIR tests that are testing the translation of LLVM MLIR dialect to LLVM IR, there are tests for argument attributes
https://github.com/llvm/llvm-project/blob/99e1308c41b24e2422324d68be28e5370196e5d6/mlir/test/Target/LLVMIR/call-argument-attributes.mlir
So usually, it is better to limit flang unit tests to test the steps implemented in flang. However, given there are several steps involved here, and given the MLIR tests to not test sret, it sounds reasonable to add a small integration test from Fortran to LLVM IR.
I added one.
https://github.com/llvm/llvm-project/pull/126896
More information about the flang-commits
mailing list